[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH for-2.1] block: Fix bdrv_is_allocated() return value
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PATCH for-2.1] block: Fix bdrv_is_allocated() return value |
Date: |
Mon, 7 Jul 2014 17:37:26 +0200 |
bdrv_is_allocated() should return either 0 or 1 in successful cases.
We're lucky that currently, the callers that rely on this (e.g. because
they check for ret == 1) don't seem to break badly. They just might skip
some optimisation or in the case of qemu-io 'map' print separate lines
where a single line would suffice. In theory, a wrong allocation status
could lead to image corruption with certain operations, so let's fix
this quickly.
Signed-off-by: Kevin Wolf <address@hidden>
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block.c b/block.c
index f80e2b2..e2e9cbb 100644
--- a/block.c
+++ b/block.c
@@ -4039,7 +4039,7 @@ int coroutine_fn bdrv_is_allocated(BlockDriverState *bs,
int64_t sector_num,
if (ret < 0) {
return ret;
}
- return (ret & BDRV_BLOCK_ALLOCATED);
+ return !!(ret & BDRV_BLOCK_ALLOCATED);
}
/*
--
1.8.3.1
- [Qemu-devel] [PATCH for-2.1] block: Fix bdrv_is_allocated() return value,
Kevin Wolf <=