qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH for-2.1] test-string-output-visitor: Fix unterminate


From: Kevin Wolf
Subject: [Qemu-devel] [PATCH for-2.1] test-string-output-visitor: Fix unterminated string
Date: Wed, 9 Jul 2014 16:14:48 +0200

Don't forget to add a terminating '\0' or the test case will be randomly
failing. The broken code was added in commit b4900c0e.

Signed-off-by: Kevin Wolf <address@hidden>
---
 tests/test-string-output-visitor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/test-string-output-visitor.c 
b/tests/test-string-output-visitor.c
index e89e43c..f2c427f 100644
--- a/tests/test-string-output-visitor.c
+++ b/tests/test-string-output-visitor.c
@@ -201,11 +201,11 @@ static void test_visitor_out_enum(TestOutputVisitorData 
*data,
         visit_type_EnumOne(data->ov, &i, "unused", &err);
         g_assert(!err);
 
-        len = strlen(EnumOne_lookup[i]) + 2;
+        len = strlen(EnumOne_lookup[i]) + 3;
         str_human = g_malloc0(len);
         str_human[0] = '"';
         strncpy(str_human + 1, EnumOne_lookup[i], strlen(EnumOne_lookup[i]));
-        str_human[len - 1] = '"';
+        str_human[len - 2] = '"';
 
         str = string_output_get_string(data->sov);
         g_assert(str != NULL);
-- 
1.8.3.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]