[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/10] aio-win32: add aio_set_dispatching optimizati
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 07/10] aio-win32: add aio_set_dispatching optimization |
Date: |
Wed, 9 Jul 2014 11:53:07 +0200 |
Signed-off-by: Paolo Bonzini <address@hidden>
---
aio-win32.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/aio-win32.c b/aio-win32.c
index 1ec434a..fd52686 100644
--- a/aio-win32.c
+++ b/aio-win32.c
@@ -144,12 +144,25 @@ bool aio_poll(AioContext *ctx, bool blocking)
{
AioHandler *node;
HANDLE events[MAXIMUM_WAIT_OBJECTS + 1];
- bool progress, first;
+ bool was_dispatching, progress, first;
int count;
int timeout;
+ was_dispatching = ctx->dispatching;
progress = false;
+ /* aio_notify can avoid the expensive event_notifier_set if
+ * everything (file descriptors, bottom halves, timers) will
+ * be re-evaluated before the next blocking poll(). This is
+ * already true when aio_poll is called with blocking == false;
+ * if blocking == true, it is only true after poll() returns.
+ *
+ * If we're in a nested event loop, ctx->dispatching might be true.
+ * In that case we can restore it just before returning, but we
+ * have to clear it now.
+ */
+ aio_set_dispatching(ctx, !blocking);
+
ctx->walking_handlers++;
/* fill fd sets */
@@ -170,6 +183,7 @@ bool aio_poll(AioContext *ctx, bool blocking)
timeout = blocking
? qemu_timeout_ns_to_ms(aio_compute_timeout(ctx)) : 0;
ret = WaitForMultipleObjects(count, events, FALSE, timeout);
+ aio_set_dispatching(ctx, true);
if (first && aio_bh_poll(ctx)) {
progress = true;
@@ -191,5 +205,6 @@ bool aio_poll(AioContext *ctx, bool blocking)
progress |= timerlistgroup_run_timers(&ctx->tlg);
+ aio_set_dispatching(ctx, was_dispatching);
return progress;
}
--
1.9.3
- [Qemu-devel] [PATCH for-2.2 00/10] AioContext cleanups and Win32 socket support, Paolo Bonzini, 2014/07/09
- [Qemu-devel] [PATCH 01/10] AioContext: take bottom halves into account when computing aio_poll timeout, Paolo Bonzini, 2014/07/09
- [Qemu-devel] [PATCH 03/10] aio-win32: Factor out duplicate code into aio_dispatch_handlers, Paolo Bonzini, 2014/07/09
- [Qemu-devel] [PATCH 02/10] aio-win32: Evaluate timers after handles, Paolo Bonzini, 2014/07/09
- [Qemu-devel] [PATCH 04/10] AioContext: run bottom halves after polling, Paolo Bonzini, 2014/07/09
- [Qemu-devel] [PATCH 05/10] AioContext: export and use aio_dispatch, Paolo Bonzini, 2014/07/09
- [Qemu-devel] [PATCH 06/10] test-aio: test timers on Windows too, Paolo Bonzini, 2014/07/09
- [Qemu-devel] [PATCH 07/10] aio-win32: add aio_set_dispatching optimization,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 08/10] AioContext: introduce aio_prepare, Paolo Bonzini, 2014/07/09
- [Qemu-devel] [PATCH 09/10] qemu-coroutine-io: fix for Win32, Paolo Bonzini, 2014/07/09
- [Qemu-devel] [PATCH 10/10] aio-win32: add support for sockets, Paolo Bonzini, 2014/07/09