Re: [Qemu-devel] [PATCH 01/15] target-tricore: Add target stubs and qom-cpu

[Peter Maydell]

On 11 July 2014 12:05, Bastian Koppelmann
<address@hidden> wrote:
> On 07/07/2014 08:24 PM, Peter Maydell wrote:
>> I think you probably want the configure and default-configs changes to be
>> at the end of the patch series (or at least part way through it), not at the
>> start. The general approach is: * some patches which implement the basic
>> absolute minimum functionality, usefully split up * then add the configure
>> and default-configs changes that allow the user to select the target and
>> include it in the default target list
>
> Would you recommend to add the part, which activates the target, at the end
> of this patch series or at the end of the implementation of the target?

I would add it at the point where the target can at least build
and attempt to execute a guest binary, even if every instruction
is actually undefined.

thanks
-- PMM