Re: [Qemu-devel] [PATCH] linux-user: Add binfmt wrapper

[Joakim Tjernlund]

Alexander Graf <address@hidden> wrote on 2014/07/14 18:34:34:
> 
> 
> On 14.07.14 18:32, Joakim Tjernlund wrote:
> > Alexander Graf <address@hidden> wrote on 2014/07/14 18:00:35:
> > You think everyone feel OK with new defaults like OP ?
> >> Yes.
> > hmm, with current qemu it works to boot a LXC with just O flag.
> > Why would we then want to complicate things by adding OP which
> > then requires some version of my patch?
> 
> How does current QEMU boot anything with the 0 flag? It doesn't know how 

> to handle it and will misinterpret the argument, no?

Playing some, one could possibly do both:

-    if (i > 0 && strcmp(binfmt, "-binfmt-wrapper") == 0) {
+    execfd = qemu_getauxval(AT_EXECFD);
+    if (execfd > 0 || i > 0 && strcmp(binfmt, "-binfmt-wrapper") == 0) {