|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH for-2.1? 2/2] thread-pool: avoid deadlock in nested aio_poll() calls |
Date: | Tue, 15 Jul 2014 17:21:21 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
Il 15/07/2014 16:37, Stefan Hajnoczi ha scritto:
> This is of course missing here: > > break;Let's keep goto restart so we don't use the BH for each completion callback. We just need the BH scheduled once to protect against the deadlock.
Ah, I missed this remark.Then you could add qemu_bh_cancel at the end of the BH handler. I do find the code a little harder to follow with the "goto" though, as it's not clear who will take care of the rest of the list...
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |