[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tests/Makefile: Only run vhost-user-test on Lin
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] tests/Makefile: Only run vhost-user-test on Linux |
|
Date: |
Tue, 15 Jul 2014 21:30:57 +0100 |
On 15 July 2014 21:15, Paolo Bonzini <address@hidden> wrote:
> Il 15/07/2014 19:35, Peter Maydell ha scritto:
>
>> vhost-user-test uses the linux/vhost.h header, so it must only be
>> enabled if CONFIG_LINUX is defined. (Previously it was enabled
>> for CONFIG_POSIX, which broke 'make check' on MacOSX.)
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> I'm going to commit this for the 2.1-rc2 tag I'm about to do,
>> since it's such a trivial change...
>
>
> Yes, the right thing to do is probably to distribute linux/vhost.h but it's
> 2.2 material.
That's tricky unless the kernel folks are going to guarantee
that they'll keep that header compilable on every host OS
we support... (I have a similar issue with psci.h, so if you have
a solution to this I'd like to use it there too.)
-- PMM