Re: [Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

[Fam Zheng]

On Thu, 07/17 19:50, Liu Yuan wrote:
> - allow drive-mirror to create sprase mirror on images like qcow2
> - allow qemu-img map to work as expected on quorum driver
> 
> Cc: Benoit Canet <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Liu Yuan <address@hidden>
> ---
>  block/quorum.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/block/quorum.c b/block/quorum.c
> index ebf5c71..f0d0a98 100644
> --- a/block/quorum.c
> +++ b/block/quorum.c
> @@ -780,6 +780,21 @@ static coroutine_fn int quorum_co_flush(BlockDriverState 
> *bs)
>      return result;
>  }
>  
> +static int64_t coroutine_fn quorum_co_get_block_status(BlockDriverState *bs,
> +                                                       int64_t sector_num,
> +                                                       int nb_sectors,
> +                                                       int *pnum)
> +{
> +    BDRVQuorumState *s = bs->opaque;
> +    BlockDriverState *child_bs = s->bs[0];

Should we consider other children?

Fam

> +
> +    if (child_bs->drv->bdrv_co_get_block_status)
> +        return child_bs->drv->bdrv_co_get_block_status(child_bs, sector_num,
> +                                                       nb_sectors, pnum);
> +
> +    return bdrv_get_block_status(child_bs, sector_num, nb_sectors, pnum);
> +}
> +