|
From: | Marcin Gibuła |
Subject: | Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration |
Date: | Fri, 18 Jul 2014 11:32:45 +0200 |
User-agent: | Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
The name of the hack^Wfunction is tricky, because compared to do_kvm_cpu_synchronize_state there are three things you change: 1) you always synchronize the state 2) the next call to do_kvm_cpu_synchronize_state will do kvm_arch_get_registers
Yes.
3) the next CPU entry will call kvm_arch_put_registers: if (cpu->kvm_vcpu_dirty) { kvm_arch_put_registers(cpu, KVM_PUT_RUNTIME_STATE); cpu->kvm_vcpu_dirty = false; }
But, I don't set cpu->kvm_vcpu_dirty anywhere (?).
I still lean very much towards reverting the patches now. We can reapply them, fixed, in 2.1.1.
That's probably good idea. -- mg
[Prev in Thread] | Current Thread | [Next in Thread] |