Re: [Qemu-devel] [PATCH v4 7/8] BitmapLog: get the information about the parameters

[Sanidhya Kashyap]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> 

> No need to abbreviate.  And given my naming question in 3/8, would
> this be better as: current-iteration
> 

Okay, I will surely modify it.

>> +# +# @epochs: provides the information about the actual epoch
> 
> and iterations
> 
> Wait.  Is this number a constant (the number requested when
> logging started, no matter what currepoch is)...[1]
> 

yup.

> Most query interfaces are in the query- namespace.  Maybe this
> would be better as query-log-dirty-bitmap?
> 

My bad, I didn't look others clearly. Since, you pointed out to use
get-tuning and set-tuning in one of my other patches; so, I used
get-tuning. Will make the relevant changes.

>> +# +# Get the current values of the parameters involved in
>> bitmap logging process
> 
> Accidental double space.
> 
>> +# +# This command returns the following elements in the form of
>> BitmapLogStateInfo: +# - currepoch: current epoch value +# -
>> epochs: total epochs for which the bitmap dumping will continue
> 
> ...[1]or is it the number of iterations remaining (that is, 
> currepoch+epochs is the original value, and both numbers are
> changing as iterations progress)?  Rather than duplicate the
> parameters in two

No, currepoch changes while the epoch is a fix value. Need to change
the names :-/. They are confusing.

> places (and with different information, which led to my question
> about semantics), it might be nicer to just mention here that the
> information is returned as a BitmapLogStateInfo and be done with it
> (the user can go look up the documentation of that struct).
> 

Will do that.

- -- 
- -----

Sanidhya Kashyap
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTyVwyAAoJEFt9RLmoahlnS1QH/36mLxnS3sblvYI6v7fJxAF0
bklZpcUKVmanLaOTY498FD8kZN2//Q5rPlJis2AiMAyZ7I1zz4JdPjW+hfjRI+Lb
KgewG4T6tP3zPzponD4EUcIrBOLlgTIuNwP7Rd+8Cpy37MkFm3MyUqU4kVwS98wS
MY99/UBEMkX/+IXLANAOjOmTIjwgg/HU2NyhMUFbR4tiYWdQCtozfr+/uBfz2tBg
AMTy3gkPTMvB/frXovBN+V2KfdJPn14oaBxdfms94SSwmsfOz1ot4j0nx1MuwoPW
XOL6t/P9W1w3V43av/NG+U2CUPo8NCb5S1MmZse5oqx1CPvbhoDIlYOySmp//Pg=
=IyAr
-----END PGP SIGNATURE-----