Re: [Qemu-devel] [PATCH v2 for-2.1 1/2] acpi-dsdt: procedurally generate _PRT

[Laszlo Ersek]

On 07/24/14 16:32, Paolo Bonzini wrote:
> This replaces the _PRT constant with a method that computes it.
> 
> The problem is that the DSDT+SSDT have grown from 2.0 to 2.1,
> enough to cross the 8k barrier (we align the ACPI tables to 4k
> before putting them in fw_cfg).  This causes problems with
> migration and the pc-i440fx-2.0 machine type.
> 
> The solution to the problem is to hardcode 64k as the limit,
> but this doesn't solve the bug with pc-i440fx-2.0.  The fix will be
> for QEMU 2.1 to use exactly the same size as QEMU 2.0 for the
> ACPI tables.  First, however, we must make the actual AML
> equal or smaller; to do this, rewrite _PRT in a way that saves
> over 1k of bytecode.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>       include cpi-dsdt.hex.generated [Igor]
> 
>  hw/i386/acpi-dsdt.dsl           |   90 +-
>  hw/i386/acpi-dsdt.hex.generated | 1910 
> +++------------------------------------
>  2 files changed, 148 insertions(+), 1852 deletions(-)

Compared with v1, v2 1/2 seems to reword the commit message a little
bit, and add the generated file (requested by Igor, and mentioned by you
anyway).

Reviewed-by: Laszlo Ersek <address@hidden>