|
From: | mateusz.krzywicki |
Subject: | Re: [Qemu-devel] Possible null-ptr dereference |
Date: | Mon, 28 Jul 2014 08:20:12 +0000 |
Hey,
Yup, thanks, task closed ;-) Best regards, Mateusz Krzywicki From: address@hidden To: address@hidden; address@hidden CC: address@hidden; address@hidden Subject: RE: [Qemu-devel] Possible null-ptr dereference Date: Mon, 28 Jul 2014 06:03:45 +0000 Hi,
Should be easy to fix though. Does the following help?
(Cc’ing Stefan & Kevin)
--> xen_disk: fix possible null-ptr dereference
Signed-off-by: Gonglei <address@hidden> --- hw/block/xen_disk.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index aed5b5b..a221d0b 100644 --- a/hw/block/xen_disk.c +++ b/hw/block/xen_disk.c @@ -589,6 +589,7 @@ static int blk_send_response_one(struct ioreq *ioreq) break; default: dst = NULL; + return 0; } memcpy(dst, &resp, sizeof(resp)); blkdev->rings.common.rsp_prod_pvt++; --
Best regards, -Gonglei
From: address@hidden [mailto:address@hidden
On Behalf Of address@hidden
Hey,
Found a little bug in latest qemu:
In function: static int blk_send_response_one(struct ioreq *ioreq)
File: qemu\hw\block\xen_disk.c
Code:
default: dst = NULL; } memcpy(dst, &resp, sizeof(resp));
Just add simple check for dst and it will be all cool ;-)
Best regards, Mateusz Krzywicki |
[Prev in Thread] | Current Thread | [Next in Thread] |