[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/8] block/qcow2: Implement status CB for amend
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/8] block/qcow2: Implement status CB for amend |
Date: |
Wed, 30 Jul 2014 09:23:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/25/2014 12:07 PM, Max Reitz wrote:
> The only really time-consuming operation potentially performed by
> qcow2_amend_options() is zero cluster expansion when downgrading qcow2
> images from compat=1.1 to compat=0.10, so report status of that
> operation and that operation only through the status CB.
>
> For this, count the number of L2 zero entries, use this as the basis for
> the total "amend job length" and increase the current offset by the
> cluster size multiplied by the refcount of the L2 table when expanding
> zero clusters.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/qcow2-cluster.c | 145
> ++++++++++++++++++++++++++++++++++++++++++++++++--
> block/qcow2.c | 9 ++--
> block/qcow2.h | 3 +-
> 3 files changed, 147 insertions(+), 10 deletions(-)
>
Makes sense, although I'll defer R-b until I've looked at both competing
series in entirety.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 0/8] block/qcow2: Improve (?) zero cluster expansion, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 2/8] qemu-img: Add progress output for amend, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 3/8] qemu-img: Fix insignifcant memleak, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 4/8] block/qcow2: Make get_refcount() global, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 5/8] block/qcow2: Implement status CB for amend, Max Reitz, 2014/07/25
- Re: [Qemu-devel] [PATCH 5/8] block/qcow2: Implement status CB for amend,
Eric Blake <=
- [Qemu-devel] [PATCH 6/8] block/qcow2: Simplify shared L2 handling in amend, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 7/8] block/qcow2: Speed up zero cluster expansion, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 8/8] iotests: Expand test 061, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 1/8] block: Add status callback to bdrv_amend_options(), Max Reitz, 2014/07/25