Re: [Qemu-devel] [RFC PATCH v3 10/49] rtl8139: adding new fields to vmstate

[Paolo Bonzini]

Il 31/07/2014 17:49, Pavel Dovgalyuk ha scritto:
> We cannot calculate timers in post_load, because it requires correct
> value of virtual clock. And at that moment replay data structures could
> be not loaded yet.

Then this patch (and similarly others in this early part of the series)
should be properly named "work around deficiencies of replay", not "add
new fields to vmstate".

Replay of course has to do _more_ things than migration.  However,
anything that makes replay _different_ from migration, for things that
migration already does, is not going to fly.  It means instant bitrot,
and will not be accepted without very good justification.

timers_state is serialized before everything else for a reason.  If you
need to serialize more state for replay to work, add it to a subsection
of timers_state that is only included during record.

Paolo