Re: [Qemu-devel] [PATCH] virtio: Move extern declaration to header file

[Michael Tokarev]

07.07.2014 23:13, Stefan Weil wrote:
[]
> index 35316c4..ff4f200 100644
> --- a/hw/virtio/vhost-backend.c
> +++ b/hw/virtio/vhost-backend.c
> @@ -14,8 +14,6 @@
>  
>  #include <sys/ioctl.h>
>  
> -extern const VhostOps user_ops;
> -

BTW, it looks like we still have just one VhostOps - this user_ops one -
despite commit 24d1eb33eb2ccd995a which was aimed to add another ops
(kernel) back in May.  Maybe we should not add extra indirection without
a reason, before it is actually used?

Also, "user_ops" is way too generic name.  Maybe user_vhost_ops or something.

Just.. saying.

Thanks,

/mjt