[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 01/24] qmp: Extract system emulation related
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1 01/24] qmp: Extract system emulation related code from qmp.c into qmp-system.c |
Date: |
Tue, 05 Aug 2014 06:40:12 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 07/31/2014 11:26 PM, Benoît Canet wrote:
> This patch will allow to link qmp.o with utility binaries without dragging too
s/allow to link/allow linking/
> much unrelated object files and externals dependencies.
s/dragging too much/dragging in too many/
s/externals/external/
>
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> Makefile.objs | 2 +-
> qmp-system.c | 376
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> qmp.c | 361 +------------------------------------------------------
> 3 files changed, 379 insertions(+), 360 deletions(-)
> create mode 100644 qmp-system.c
>
When reviewing code motion, I like to do:
$ diff -u <(sed -n 's/^-//p' patch) <(sed -n 's/^+//p' patch)
In the case of this patch, you rearranged functions, which makes it MUCH
harder to see if everything moved correctly (for example, the old code
has qmp_query_kvm, qmp_query_uuid, qmp_quit, qmp_stop...; the new code
has them in a different order). It would be a lot easier if you create
the new file with the function order preserved as it was in the original
file.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v1 00/24] Extract qmp.c and monitor.c core and wire QMP into qemu-nbd, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 02/24] monitor: Make some function public, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 03/24] monitor: Extract monitor-system.h header, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 04/24] monitor: Make monitor_fprintf public before extracting it, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 09/24] monitor: Make do_info_help public, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 01/24] qmp: Extract system emulation related code from qmp.c into qmp-system.c, Benoît Canet, 2014/08/01
- Re: [Qemu-devel] [PATCH v1 01/24] qmp: Extract system emulation related code from qmp.c into qmp-system.c,
Eric Blake <=
- [Qemu-devel] [PATCH v1 06/24] monitor: Extract qmp_human_monitor_command into monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 13/24] monitor: Move do_loadvm from monitor.c to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 08/24] monitor: Extract a couple of function to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 05/24] monitor: Extract monitor_fprintf to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 22/24] qemu-nbd: build QAPI block core into qemu-nbd, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 16/24] monitor: Move more functions from monitor.c to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 07/24] monitor: Make some function to extract public, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 12/24] monitor: Make do_loadvm public before moving it to monitor-system.c, Benoît Canet, 2014/08/01
- [Qemu-devel] [PATCH v1 23/24] qapi: Add a script to filter qmp-commands-old.h to generate a subset of it., Benoît Canet, 2014/08/01