[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/6] tcg-sparc: Fix setcond_i32 uninitialized value
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 3/6] tcg-sparc: Fix setcond_i32 uninitialized value |
Date: |
Wed, 6 Aug 2014 09:49:37 -1000 |
We failed to swap c1 and c2 correctly for NE c2 == 0.
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/sparc/tcg-target.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tcg/sparc/tcg-target.c b/tcg/sparc/tcg-target.c
index 08ca482..3b232d6 100644
--- a/tcg/sparc/tcg-target.c
+++ b/tcg/sparc/tcg-target.c
@@ -674,9 +674,12 @@ static void tcg_out_setcond_i32(TCGContext *s, TCGCond
cond, TCGReg ret,
case TCG_COND_NE:
/* For equality, we can transform to inequality vs zero. */
if (c2 != 0) {
- tcg_out_arithc(s, ret, c1, c2, c2const, ARITH_XOR);
+ tcg_out_arithc(s, TCG_REG_T1, c1, c2, c2const, ARITH_XOR);
+ c2 = TCG_REG_T1;
+ } else {
+ c2 = c1;
}
- c1 = TCG_REG_G0, c2 = ret, c2const = 0;
+ c1 = TCG_REG_G0, c2const = 0;
cond = (cond == TCG_COND_EQ ? TCG_COND_GEU : TCG_COND_LTU);
break;
--
1.9.3
- [Qemu-devel] [PATCH 0/6] tcg sparc improvements, Richard Henderson, 2014/08/06
- [Qemu-devel] [PATCH 1/6] tcg-sparc: Support addsub2_i64, Richard Henderson, 2014/08/06
- [Qemu-devel] [PATCH 2/6] tcg-sparc: Use ADDXC in addsub2_i64, Richard Henderson, 2014/08/06
- [Qemu-devel] [PATCH 4/6] tcg-sparc: Use ADDXC in setcond_i64, Richard Henderson, 2014/08/06
- [Qemu-devel] [PATCH 3/6] tcg-sparc: Fix setcond_i32 uninitialized value,
Richard Henderson <=
- [Qemu-devel] [PATCH 5/6] tcg-sparc: Rename ADDX/SUBX insns, Richard Henderson, 2014/08/06
- [Qemu-devel] [PATCH 6/6] tcg-sparc: Use UMULXHI instruction, Richard Henderson, 2014/08/06