[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 0/7] memory API improvements and bug fixes fo
From: |
Hu Tao |
Subject: |
Re: [Qemu-devel] [PATCH v6 0/7] memory API improvements and bug fixes for memory backends |
Date: |
Fri, 15 Aug 2014 17:54:46 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Aug 07, 2014 at 09:13:49PM +1000, Peter Crosthwaite wrote:
> On Thu, Aug 7, 2014 at 7:10 PM, Hu Tao <address@hidden> wrote:
> > This series includes two parts:
> >
> > 1. part 1 includes patches 1-4, which improves error handling of
> > memory_region_init_ram, memory_region_init_ram_ptr and
> > memory_region_init_rom_device
> >
> > 2. part 2 includes patches 5-7, each fixes a bug of memory backend.
> >
> > changes to v5:
> >
> > - split patch 6 in v5 into 2
> > - use local_err instead of errp
> > - typo fixes
> >
>
> A bit of a nit, but when respinning, please keep the changelogs from
> previous spins. E.g. you should keep the "changes to v4" as you
> documented in the last cover.
>
> Aids reviewing when reviewers come to a series late or when a reviewer
> skips a spin etc,
>
> It's not an inhibiting issue on this spin, just for future reference.
Thanks, I'll do it.
>
> Regards,
> Peter
>
> > Hu Tao (7):
> > exec: add parameter errp to qemu_ram_alloc and qemu_ram_alloc_from_ptr
> > memory: add parameter errp to memory_region_init_ram
> > memory: add parameter errp to memory_region_init_ram_ptr
> > memory: add parameter errp to memory_region_init_rom_device
> > hostmem-ram: don't exit qemu if size of memory-backend-ram is way too
> > big
> > exec: report error when memory < hpagesize
> > exec: add parameter errp to gethugepagesize
> >
> > backends/hostmem-ram.c | 2 +-
> > exec.c | 60
> > ++++++++++++++++++++++----------
> > hw/alpha/typhoon.c | 3 +-
> > hw/arm/armv7m.c | 7 ++--
> > hw/arm/cubieboard.c | 2 +-
> > hw/arm/digic_boards.c | 2 +-
> > hw/arm/exynos4210.c | 9 ++---
> > hw/arm/highbank.c | 5 +--
> > hw/arm/integratorcp.c | 5 +--
> > hw/arm/kzm.c | 4 +--
> > hw/arm/mainstone.c | 3 +-
> > hw/arm/musicpal.c | 6 ++--
> > hw/arm/omap1.c | 6 ++--
> > hw/arm/omap2.c | 6 ++--
> > hw/arm/omap_sx1.c | 6 ++--
> > hw/arm/palm.c | 3 +-
> > hw/arm/pxa2xx.c | 11 +++---
> > hw/arm/realview.c | 9 +++--
> > hw/arm/spitz.c | 2 +-
> > hw/arm/strongarm.c | 3 +-
> > hw/arm/tosa.c | 2 +-
> > hw/arm/versatilepb.c | 3 +-
> > hw/arm/vexpress.c | 15 +++++---
> > hw/arm/virt.c | 3 +-
> > hw/arm/xilinx_zynq.c | 6 ++--
> > hw/block/onenand.c | 2 +-
> > hw/block/pflash_cfi01.c | 2 +-
> > hw/block/pflash_cfi02.c | 2 +-
> > hw/core/loader.c | 2 +-
> > hw/cris/axis_dev88.c | 6 ++--
> > hw/display/cg3.c | 6 ++--
> > hw/display/g364fb.c | 2 +-
> > hw/display/qxl.c | 6 ++--
> > hw/display/sm501.c | 2 +-
> > hw/display/tc6393xb.c | 3 +-
> > hw/display/tcx.c | 5 +--
> > hw/display/vga.c | 3 +-
> > hw/display/vmware_vga.c | 3 +-
> > hw/i386/kvm/pci-assign.c | 6 ++--
> > hw/i386/pc.c | 3 +-
> > hw/i386/pc_sysfw.c | 5 +--
> > hw/input/milkymist-softusb.c | 4 +--
> > hw/lm32/lm32_boards.c | 6 ++--
> > hw/lm32/milkymist.c | 3 +-
> > hw/m68k/an5206.c | 4 +--
> > hw/m68k/dummy_m68k.c | 2 +-
> > hw/m68k/mcf5208.c | 4 +--
> > hw/microblaze/petalogix_ml605_mmu.c | 5 +--
> > hw/microblaze/petalogix_s3adsp1800_mmu.c | 6 ++--
> > hw/mips/mips_fulong2e.c | 5 +--
> > hw/mips/mips_jazz.c | 8 +++--
> > hw/mips/mips_malta.c | 6 ++--
> > hw/mips/mips_mipssim.c | 6 ++--
> > hw/mips/mips_r4k.c | 5 +--
> > hw/misc/ivshmem.c | 5 +--
> > hw/misc/vfio.c | 3 +-
> > hw/moxie/moxiesim.c | 4 +--
> > hw/net/milkymist-minimac2.c | 2 +-
> > hw/openrisc/openrisc_sim.c | 2 +-
> > hw/pci-host/prep.c | 3 +-
> > hw/pci/pci.c | 2 +-
> > hw/ppc/mac_newworld.c | 3 +-
> > hw/ppc/mac_oldworld.c | 3 +-
> > hw/ppc/ppc405_boards.c | 8 +++--
> > hw/ppc/ppc405_uc.c | 3 +-
> > hw/ppc/spapr.c | 2 +-
> > hw/s390x/s390-virtio-ccw.c | 2 +-
> > hw/s390x/s390-virtio.c | 2 +-
> > hw/sh4/r2d.c | 2 +-
> > hw/sh4/shix.c | 8 +++--
> > hw/sparc/leon3.c | 4 +--
> > hw/sparc/sun4m.c | 10 +++---
> > hw/sparc64/sun4u.c | 6 ++--
> > hw/unicore32/puv3.c | 3 +-
> > hw/xtensa/sim.c | 4 +--
> > hw/xtensa/xtfpga.c | 8 +++--
> > include/exec/memory.h | 12 +++++--
> > include/exec/ram_addr.h | 4 +--
> > memory.c | 15 ++++----
> > numa.c | 4 +--
> > xen-hvm.c | 3 +-
> > 81 files changed, 270 insertions(+), 162 deletions(-)
> >
> > --
> > 1.9.3
> >
> >