Re: [Qemu-devel] [PATCH v2 0/4] qcow2: Allow runtime specification of cache sizes

[Kevin Wolf]

Am 19.08.2014 um 16:18 hat Eric Blake geschrieben:
> On 08/19/2014 08:00 AM, Kevin Wolf wrote:
> > Am 18.08.2014 um 22:07 hat Max Reitz geschrieben:
> >> Currently, the metadata cache size is only tunable on compile time
> >> through macros. However, some users may want to use the minimal cache
> >> size (for whatever reason) and others may want to increase the cache
> >> size because they have enough memory and want to increase performance.
> >>
> >> This series adds runtime options for setting the cache size in bytes
> >> (which is an easily comprehensible unit) in various ways (by setting
> >> each cache explicitly or the total size).
> >>
> >>
> >> This series (patch 2) depends on Markus' series
> >> "[PATCH v2 0/4] block: Use g_new() & friends more".
> >>
> >>
> >> v2:
> >>  - Patch 2: c->entries may be NULL in the fail path; respect that case
> > 
> > Thanks, applied all to the block branch (with patch 1 changed as
> > commented there).
> 
> I'd still like to see the changes to qapi/block-core.json that expose
> these for hot-plugging before we call this series finished (I mentioned
> that in my review of v1, without realizing that v2 had already been sent).

Yes, we need this. But Max replied there that he'd send a follow-up and
that was good enough for me because my experience is that he is one of
the few people who don't only promise follow-up patches, but actually
send them.

Kevin

pgpCbHSzaDIce.pgp
Description: PGP signature