Re: [Qemu-devel] [PULL 19/20] memory: Use canonical path component as the name

[Peter Crosthwaite]

On Wed, Aug 20, 2014 at 4:51 AM, Peter Maydell <address@hidden> wrote:
> On 19 August 2014 11:43, Paolo Bonzini <address@hidden> wrote:
>> From: Peter Crosthwaite <address@hidden>
>>
>> Rather than having the name as separate state. This prepares support
>> for creating a MemoryRegion dynamically (i.e. without
>> memory_region_init() and friends) and the MemoryRegion still getting
>> a usable name.
>>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> This commit seems to have broken builds with Xen:
>
>   CC    i386-softmmu/xen-hvm.o
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c: In function
> ‘xen_add_to_physmap’:
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c:333:31: error:
> ‘MemoryRegion’ has no member named ‘name’
>      physmap->name = (char *)mr->name;
>                                ^
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c:357:11: error:
> ‘MemoryRegion’ has no member named ‘name’
>      if (mr->name) {
>            ^
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c:361:51: error:
> ‘MemoryRegion’ has no member named ‘name’
>          if (!xs_write(state->xenstore, 0, path, mr->name, strlen(mr->name))) 
> {
>                                                    ^
> /home/petmay01/linaro/qemu-for-merges/xen-hvm.c:361:68: error:
> ‘MemoryRegion’ has no member named ‘name’
>          if (!xs_write(state->xenstore, 0, path, mr->name, strlen(mr->name))) 
> {
>                                                                     ^
> make[1]: *** [xen-hvm.o] Error 1
> make: *** [subdir-i386-softmmu] Error 2
>
>
> I should have spotted this as part of my pre-merge
> tests, but somehow it slipped through -- sorry.
>

You and me both. Added Xen to my pre-send compile testing.

The fix for this is reasonably trivial and just follows the change
pattern for the other usages as fixed in original series. Patch on
list imminently.

Regards,
Peter

> -- PMM
>