Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: add test case 101 for short file I/O

[Benoît Canet]

The Thursday 21 Aug 2014 à 13:44:08 (+0100), Stefan Hajnoczi wrote :
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  tests/qemu-iotests/101     | 58 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/101.out | 10 ++++++++
>  tests/qemu-iotests/group   |  1 +
>  3 files changed, 69 insertions(+)
>  create mode 100755 tests/qemu-iotests/101
>  create mode 100644 tests/qemu-iotests/101.out
> 
> diff --git a/tests/qemu-iotests/101 b/tests/qemu-iotests/101
> new file mode 100755
> index 0000000..70fbf25
> --- /dev/null
> +++ b/tests/qemu-iotests/101
> @@ -0,0 +1,58 @@
> +#!/bin/bash
> +#
> +# Test short file I/O
> +#
> +# Copyright (C) 2014 Red Hat, Inc.
> +#
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +
> +# creator
> address@hidden
> +
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1     # failure is the default!
> +
> +_cleanup()
> +{
> +     _cleanup_test_img
> +}
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +
> +_supported_fmt raw
> +_supported_proto file
> +_supported_os Linux
> +
> +
> +echo
> +echo "== creating short image file =="
> +dd if=/dev/zero of="$TEST_IMG" bs=1 count=320
> +
> +echo
> +echo "== reading bytes beyond EOF gives zeroes =="

We could pad the file with 0xFF to make sure the read really get only zeroes.

Reviewed-by: Benoît Canet <address@hidden>

> +$QEMU_IO -c "read -P 0 0 512" "$TEST_IMG" | _filter_qemu_io
> +
> +
> +# success, all done
> +echo "*** done"
> +rm -f $seq.full
> +status=0
> diff --git a/tests/qemu-iotests/101.out b/tests/qemu-iotests/101.out
> new file mode 100644
> index 0000000..9a996e8
> --- /dev/null
> +++ b/tests/qemu-iotests/101.out
> @@ -0,0 +1,10 @@
> +QA output created by 101
> +
> +== creating short image file ==
> +320+0 records in
> +320+0 records out
> +
> +== reading bytes beyond EOF gives zeroes ==
> +read 512/512 bytes at offset 0
> +512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +*** done
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 6e67f61..e25e992 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -100,3 +100,4 @@
>  091 rw auto quick
>  092 rw auto quick
>  095 rw auto quick
> +101 rw auto quick
> -- 
> 1.9.3
> 
>