[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] qemu-img: Allow source cache mode specif
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] qemu-img: Allow source cache mode specification |
Date: |
Fri, 22 Aug 2014 14:55:22 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.07.2014 um 22:58 hat Max Reitz geschrieben:
> Currently, qemu-img does not allow setting the cache mode for source
> images. However, it reads images generally only once, therefore a full
> writeback cache unnecessarily clutters the host cache. In case the user
> finds this undesirable, there has to be a way of disabling that cache.
> This series first introduces such a way for check, compare, convert and
> rebase and then (while at it) adds a cache mode switch to amend (which
> was missing so far).
>
> Peter already tried to add a BDRV_O_SEQUENTIAL mode to qemu-img convert.
> If we want to add such a mode (which in my opinion would be the logical
> consequence of this series), we may want to make it just another cache
> mode which can be selected by the user.
>
> v2:
> - Patch 1:
> - Remove superfluous space in qemu-img-cmds.hx [Eric]
> - Reorder all getopt() optstrings which are touched by this patch
> anyway according to the subsequent switch [Eric (implicitly)]
> - Patch 2:
> - Reorder img_amend()'s optstring [Eric]
Thanks, applied all to the block branch.
Kevin