Re: [Qemu-devel] [PATCH v2 4/4] target-openrisc: Add LPC32XX touchscreen device

[Eric Blake]

[meta-comment]

On 08/22/2014 11:06 AM, Valentin Manea wrote:
> The LPC32XX is a simple MMIO touch screen device with a Linux device
> driver. The device is suitable for small machines which require mouse
> input but have no suitable bus(SPI, I2C).

You did deep threading (patch 4 was in-reply to all four of 0/4, 1/4,
2/4, and 3/4):

0/4
+ 1/4
  + 2/4
    + 3/4
      + 4/4

which leads to awkward review tree layouts in many mailers (where the
algorithm is to list all message in-reply-to to a common parent in date
order):

0/4
+ 1/4
  + 2/4
  | + 3/4
  | | + 4/4
  | | | + Re: 4/4
  | | + Re: 3/4
  | + Re: 2/4
  + Re: 1/4

We prefer shallow threading (git send-email's default, if you don't mess
with configuration variables, where patch 4 is in-reply-to _only_ 0/4):

0/4
+ 1/4
+ 2/4
+ 3/4
+ 4/4

which also leads to nicer review tree layouts:

0/4
+ 1/4
| + Re: 1/4
+ 2/4
| + Re: 2/4
+ 3/4
| + Re: 3/4
+ 4/4
  + Re: 4/4

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature