[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding |
Date: |
Mon, 25 Aug 2014 00:52:58 +0200 |
On Sun, Aug 24, 2014 at 03:32:20PM +0200, Knut Omang wrote:
> Signed-off-by: Knut Omang <address@hidden>
BTW pcie_cap_is_arifwd_enabled is still unused.
We really should use it to make ARI work properly, right?
> ---
> hw/pci-bridge/ioh3420.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c
> index e6674a1..cce2fdd 100644
> --- a/hw/pci-bridge/ioh3420.c
> +++ b/hw/pci-bridge/ioh3420.c
> @@ -85,6 +85,7 @@ static void ioh3420_reset(DeviceState *qdev)
> pcie_cap_root_reset(d);
> pcie_cap_deverr_reset(d);
> pcie_cap_slot_reset(d);
> + pcie_cap_arifwd_reset(d);
> pcie_aer_root_reset(d);
> pci_bridge_reset(qdev);
> pci_bridge_disable_base_limit(d);
> @@ -119,6 +120,7 @@ static int ioh3420_initfn(PCIDevice *d)
> goto err_msi;
> }
>
> + pcie_cap_arifwd_init(d);
> pcie_cap_deverr_init(d);
> pcie_cap_slot_init(d, s->slot);
> pcie_chassis_create(s->chassis);
> --
> 1.9.0
- [Qemu-devel] [PATCH v2 0/4] q35: Minor fixes/enhancements to improve usability of root ports, Knut Omang, 2014/08/24
- [Qemu-devel] [PATCH v2 1/4] pcie: Fix incorrect write to the ari capability next function field, Knut Omang, 2014/08/24
- [Qemu-devel] [PATCH v2 2/4] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_*, Knut Omang, 2014/08/24
- [Qemu-devel] [PATCH v2 3/4] ioh3420: Remove obsoleted, unused ioh3420_init function, Knut Omang, 2014/08/24
- [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding, Knut Omang, 2014/08/24
- Re: [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding,
Michael S. Tsirkin <=
Re: [Qemu-devel] [PATCH v2 0/4] q35: Minor fixes/enhancements to improve usability of root ports, Michael S. Tsirkin, 2014/08/24