[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] libdecnumber: Fix warnings from
|
From: |
Tom Musta |
|
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] libdecnumber: Fix warnings from smatch (missing static, boolean operations) |
|
Date: |
Mon, 25 Aug 2014 08:49:08 -0500 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 8/24/2014 4:42 AM, Stefan Weil wrote:
> Am 24.08.2014 11:21, schrieb Michael Tokarev:
>> Applied to -trivial, thank you!
>>
>> But I've a small concern - should we really do this on "external" sources,
>> and divirge from upstream needlessly?
>>
>> Thanks,
>>
>> /mjt
>
> In general, I agree. In this case, the code was part of gcc, and newer
> versions of gcc use GPL 3 which is incompatible with QEMU, so I assume that
> the code in QEMU is no longer available from a maintained upstream.
>
> Stefan
>
>
>
Yes. We had to effectively fork a copy the code to deal with the license
issues.
FWIW ... Alex has suggested a reformat of the libdecnumber code to make it
compatible with QEMU formatting
(http://lists.nongnu.org/archive/html/qemu-ppc/2014-05/msg00085.html). This is
on my todo list. Obviously, such a reformat would make it even
harder to synchronize with upstream gcc.