[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] ide: Fix bootindex for bus_id > 9
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] ide: Fix bootindex for bus_id > 9 |
Date: |
Tue, 26 Aug 2014 11:51:15 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Aug 15, 2014 at 01:32:37PM +0200, Markus Armbruster wrote:
> We identify devices by their Open Firmware device paths. The encoding
> of bus numbers is incorrect: idebus_get_fw_dev_path() formats them in
> decimal, while SeaBIOS uses hexadecimal. With bus number > 9, SeaBIOS
> will miss the bootindex (lucky case), or apply it to another device
> (unlucky case).
>
> Bug can't bite right now: ich9-ahci has six ports, and the sysbus-ahci
> created by Calxeda Highbank has just one.
>
> Fix it anyway, by changing %d to %x.
>
> I couldn't find an Open Firmware spec covering this. For what it's
> worth, OVMF agrees with SeaBIOS.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/ide/qdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
pgps4Om3Q9wRz.pgp
Description: PGP signature