[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] checkpatch.pl: adjust typedef definition to QEM
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] checkpatch.pl: adjust typedef definition to QEMU coding style |
Date: |
Tue, 26 Aug 2014 13:19:29 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> Most QEMU typedefs are camelcase, starting with one uppercase letter
> and containing at least one lowercase letter. There are a few
> all-uppercase types, add the most common too.
>
> This fixes recognition of types in lines such as
>
> static __attribute__((unused)) inline void tcg_out8(TCGContext *s,
> uint8_t v)
>
> (Example provided by Peter Maydell).
>
> Reported-by: Alexey Kardashevskiy <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: Stefan Weil <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> scripts/checkpatch.pl | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9d46e5a..053e432 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -206,9 +206,13 @@ our $UTF8 = qr {
> | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
> }x;
>
> +# There are still some false positives, but this catches most
> +# common cases.
> our $typeTypedefs = qr{(?x:
> - (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
> - atomic_t
> + [A-Z][A-Z\d_]*[a-z][A-Za-z\d_]* # camelcase
> + | [A-Z][A-Z\d_]*AIOCB # all uppercase
> + | [A-Z][A-Z\d_]*CPU # all uppercase
> + | QEMUBH # all uppercase
> )};
>
> our $logFunctions = qr{(?x:
I had to look up \d, and then I got scared until I remembered "Perl will
not use locales unless specifically requested to". Applies both to \d
and A-Z. Consistent with existing usage, except for the position of
'|'.
Reviewed-by: Markus Armbruster <address@hidden>