Re: [Qemu-devel] [PATCH v2] curl: Allow a cookie or cookies to be sent with http/https requests.

[Richard W.M. Jones]

On Fri, Aug 29, 2014 at 09:10:10AM -0600, Eric Blake wrote:
> On 08/29/2014 09:03 AM, Richard W.M. Jones wrote:
> > In order to access VMware ESX efficiently, we need to send a session
> > cookie.  This patch is very simple and just allows you to send that
> > session cookie.  It punts on the question of how you get the session
> > cookie in the first place, but in practice you can just run a `curl'
> > command against the server and extract the cookie that way.
> > 
> 
> > +++ b/qemu-options.hx
> > @@ -2351,6 +2351,11 @@ multiple of 512 bytes. It defaults to 256k.
> >  @item sslverify
> >  Whether to verify the remote server's certificate when connecting over 
> > SSL. It
> >  can have the value 'on' or 'off'. It defaults to 'on'.
> > +
> > address@hidden cookie
> > +Send this cookie (it can also be a list of cookies separated by ';') with
> > +each outgoing request.  Only supported when using protocols such as HTTP
> > +which support cookies, otherwise ignored.
> 
> ';' has to be quoted to enter it in the shell command line (but then
> again, the cookie probably contains literal " which also has to be quoted).
> 
> We still don't have a QMP mapping for curl device hotplug.  But when we
> gain one, do we really want to have a single (long) string containing
> multiple cookies, or would it be better to make this an array argument?
>  On the command-line, which is nicer, taking the cookie option multiple
> times ('file.cookie=xyz,file.cookie.abc'), taking it as an automatic
> array ('file.cookie.0=xyz,file.cookie.1=abc') or forcing the user to
> cram all cookies into a single option ('file.cookie="xyz;abc"')?

For my immediate needs, I don't care at all about multiple cookies.
It's just a side-effect of the CURL API that they would work here.
I'm happy to drop all references to them from the documentation ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v