Re: [Qemu-devel] [PATCH 05/10] target-arm: Implement setting of watchpoints

[Richard Henderson]

On 08/29/2014 04:21 AM, Peter Maydell wrote:
> +        /* Watchpoint covers an aligned area up to 2GB in size */
> +        len = 1ULL << mask;
> +        /* If masked bits in WVR are not zero it's CONSTRAINED UNPREDICTABLE
> +         * whether the watchpoint fires when the unmasked bits match; we opt
> +         * to generate the exceptions.
> +         */
> +        wvr &= (len - 1);

This looks funny... address being clipped to length?
Surely it's ~(len - 1)...


r~