[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] block: Introduce "null" drivers
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v5] block: Introduce "null" drivers |
Date: |
Tue, 2 Sep 2014 10:46:21 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 01, 2014 at 05:22:04PM +0800, Fam Zheng wrote:
> +{ 'type': 'BlockdevOptionsNull',
> + 'base': 'BlockdevOptionsFile',
> + 'data': { '*size': 'int' } }
Why inherit from BlockdevOptionsFile?
No other blockdev options type does that. Unless there is a real
inheritance relationship, please don't do this.
Stefan
pgp34pyNcGjY8.pgp
Description: PGP signature