[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/5] qemu-char: Convert udp backend to QAPI
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/5] qemu-char: Convert udp backend to QAPI |
Date: |
Tue, 02 Sep 2014 14:04:02 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 09/02/2014 04:24 AM, Peter Maydell wrote:
> Convert the udp char backend to the new style QAPI framework.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> qemu-char.c | 69
> +++++++++++++++++++++++++++++++++++++++++++++++--------------
> 1 file changed, 54 insertions(+), 15 deletions(-)
>
> +
> + if (host == NULL || strlen(host) == 0) {
> + host = "localhost";
> + }
> + if (port == NULL || strlen(port) == 0) {
> + error_setg(errp, "chardev: udp: remote port not specified");
In the common case of these strings being non-empty, you end up having
to hunt for the end of the string only to then throw that information
away. Rather than 'strlen(foo) == 0)', it's slightly faster to check
'*foo' for being a non-NUL byte.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI, Peter Maydell, 2014/09/02
- [Qemu-devel] [PATCH v2 3/5] qemu-char: Convert udp backend to QAPI, Peter Maydell, 2014/09/02
- Re: [Qemu-devel] [PATCH v2 3/5] qemu-char: Convert udp backend to QAPI,
Eric Blake <=
- [Qemu-devel] [PATCH v2 2/5] util/qemu-sockets.c: Support specifying IPv4 or IPv6 in socket_dgram(), Peter Maydell, 2014/09/02
- [Qemu-devel] [PATCH v2 5/5] qemu-char: Rename register_char_driver_qapi() to register_char_driver(), Peter Maydell, 2014/09/02
- [Qemu-devel] [PATCH v2 1/5] qemu-char: Convert socket backend to QAPI, Peter Maydell, 2014/09/02
- [Qemu-devel] [PATCH v2 4/5] qemu-char: Remove register_char_driver() machinery, Peter Maydell, 2014/09/02
- Re: [Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI, Paolo Bonzini, 2014/09/09