qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] net: invoke callback when purging queue


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH 1/3] net: invoke callback when purging queue
Date: Thu, 04 Sep 2014 17:58:10 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0

On 09/04/2014 04:39 PM, Michael S. Tsirkin wrote:
> devices rely on packet callbacks eventually running,
> but we violate this rule whenever we purge the queue.
> To fix, invoke callbacks on all packets on purge.
> Set length to 0, this way callers can detect that
> this happened and re-queue if necessary.
>
> Cc: address@hidden
> Cc: Jason Wang <address@hidden>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  net/queue.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/net/queue.c b/net/queue.c
> index 859d02a..f948318 100644
> --- a/net/queue.c
> +++ b/net/queue.c
> @@ -233,6 +233,9 @@ void qemu_net_queue_purge(NetQueue *queue, NetClientState 
> *from)
>          if (packet->sender == from) {
>              QTAILQ_REMOVE(&queue->packets, packet, entry);
>              queue->nq_count--;
> +            if (packet->sent_cb) {
> +                packet->sent_cb(packet->sender, 0);
> +            }
>              g_free(packet);
>          }
>      }

Acked-by: Jason Wang <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]