[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/7] virtio: don't call device on !vm_running
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 4/7] virtio: don't call device on !vm_running |
Date: |
Thu, 4 Sep 2014 16:50:08 +0100 |
From: "Michael S. Tsirkin" <address@hidden>
On vm stop, virtio changes vm_running state
too soon, so callbacks can get envoked with
vm_running = false;
Cc: address@hidden
Cc: Jason Wang <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/virtio/virtio.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 5c98180..ac22238 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -1108,7 +1108,10 @@ static void virtio_vmstate_change(void *opaque, int
running, RunState state)
BusState *qbus = qdev_get_parent_bus(DEVICE(vdev));
VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(qbus);
bool backend_run = running && (vdev->status & VIRTIO_CONFIG_S_DRIVER_OK);
- vdev->vm_running = running;
+
+ if (running) {
+ vdev->vm_running = running;
+ }
if (backend_run) {
virtio_set_status(vdev, vdev->status);
@@ -1121,6 +1124,10 @@ static void virtio_vmstate_change(void *opaque, int
running, RunState state)
if (!backend_run) {
virtio_set_status(vdev, vdev->status);
}
+
+ if (!running) {
+ vdev->vm_running = running;
+ }
}
void virtio_init(VirtIODevice *vdev, const char *name,
--
1.9.3
- [Qemu-devel] [PULL 0/7] Net patches, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 2/7] net: don't use set/get_pointer() in set/get_netdev(), Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 1/7] net: Forbid dealing with packets when VM is not running, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 4/7] virtio: don't call device on !vm_running,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 5/7] net: invoke callback when purging queue, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 3/7] virtio-net: don't run bh on vm stopped, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 6/7] net: complete all queued packets on VM stop, Stefan Hajnoczi, 2014/09/04
- [Qemu-devel] [PULL 7/7] virtio-net: purge outstanding packets when starting vhost, Stefan Hajnoczi, 2014/09/04