Re: [Qemu-devel] [PATCH v6 0/3] Refactor device_set_realized to avoid resource leak

[Michael S. Tsirkin]

On Thu, Sep 04, 2014 at 05:48:25PM +0200, Andreas Färber wrote:
> Am 04.09.2014 17:30, schrieb Michael S. Tsirkin:
> > On Thu, Sep 04, 2014 at 10:18:23AM +0800, address@hidden wrote:
> >> From: Gonglei <address@hidden>
> >>
> >> after committing
> >>  [PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic 
> >> hotplug API
> >>
> >> If devcie hotplugging failed, will casuse resource leak.
> >> This patch series include address resouce leak and two other issuses.
> >>
> >> v6 -> v5:
> >>  - rework patch 2/3 by Peter's suggestion.
> >>  - add 'Reviewed-by' tag.
> >>  - remove a patch about PCIe hotplugging by Michael's idea.
> >>
> >> v5 -> v4:
> >>  - add patch 1/4 'Reviewed-by' tag.
> >>  - change patch 2/4, propagate firsh child unrealizing failure, and
> >>    change this patch's commit message.(Peter)
> >>
> >> v4 -> v3:
> >>  - add patch 2/4.(Thanks for Peter's suggestion)
> >>  - rework patch 3/4 based on patch 2/4.
> >>
> >> v3 -> v2:
> >>  - add cleanup logic for set bus/child_bus realized/unrealized failed.
> >>  - change patch 1/3 commit message, add 'Reviewed-by' tag.
> >>
> >> v2 -> v1:
> >>  - rewrite patch 1/3, using error_abort instead of local_err.
> >>  - rewrite patch 2/3, add cleanup logic for different error embranchment.
> >>  - rewrite title of patch 3/3, and a syntax fix.
> >>
> >> Gonglei (3):
> >>   qdev: using error_abort instead of using local_err
> >>   qdev: using NULL instead of local_err for qbus_child unrealize
> >>   qdev: add cleanup logic in device_set_realized() to avoid resource
> >>     leak
> > 
> > Applied and Cc qemu-stable, thanks!
> 
> Objection, patch 1/3 is already on qom-next. Please make sure to sync
> the commit message if you want to take it through your tree.
> 
> Thanks,
> Andreas

No, it's ok, I'll drop it - but please remember to notify list
when you pick up patches (if you did and I missed this somehow,
my apologies). Also pls remember to add  Cc qemu-stable in your tree.


Other QOM related patches:
hw/machine: Free old values of string properties
and
virtio-pci: fix virtio-net child refcount in transports

would you like to pick them up as well?


> > 
> >>  hw/core/qdev.c | 70 
> >> +++++++++++++++++++++++++++++++++++++++-------------------
> >>  1 file changed, 47 insertions(+), 23 deletions(-)
> >>
> >> -- 
> >> 1.7.12.4
> >>
> >>
> 
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg