[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/7] qdev: Use error_abort instead of using local_err
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL 5/7] qdev: Use error_abort instead of using local_err |
Date: |
Thu, 4 Sep 2014 19:21:13 +0200 |
From: Gonglei <address@hidden>
This error can not happen normally. If it happens, it indicates
something very wrong, we should abort QEMU. Moreover, the
user can only refer to /machine/peripheral or /objects, not
/machine/unattached.
While at it, remove superfluous check about local_err.
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
hw/core/qdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index da1ba48..4a1ac5b 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -820,13 +820,13 @@ static void device_set_realized(Object *obj, bool value,
Error **errp)
}
if (value && !dev->realized) {
- if (!obj->parent && local_err == NULL) {
+ if (!obj->parent) {
static int unattached_count;
gchar *name = g_strdup_printf("device[%d]", unattached_count++);
object_property_add_child(container_get(qdev_get_machine(),
"/unattached"),
- name, obj, &local_err);
+ name, obj, &error_abort);
g_free(name);
}
--
1.8.4.5
- [Qemu-devel] [PULL for-2.1 0/7] QOM devices patch queue 2014-09-04, Andreas Färber, 2014/09/04
- [Qemu-devel] [PULL 1/7] qom: Make object_child_foreach() safe for objects removal, Andreas Färber, 2014/09/04
- [Qemu-devel] [PULL 2/7] machine: Clean up -machine handling, Andreas Färber, 2014/09/04
- [Qemu-devel] [PULL 6/7] qdev: Use NULL instead of local_err for qbus_child unrealize, Andreas Färber, 2014/09/04
- [Qemu-devel] [PULL 5/7] qdev: Use error_abort instead of using local_err,
Andreas Färber <=
- [Qemu-devel] [PULL 3/7] qom: Add automatic arrayification to object_property_add(), Andreas Färber, 2014/09/04
- [Qemu-devel] [PULL 4/7] memory: Remove object_property_add_child_array(), Andreas Färber, 2014/09/04
- [Qemu-devel] [PULL 7/7] qdev: Add cleanup logic in device_set_realized() to avoid resource leak, Andreas Färber, 2014/09/04
- Re: [Qemu-devel] [PULL for-2.1 0/7] QOM devices patch queue 2014-09-04, Peter Maydell, 2014/09/05