[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 07/22] linux-aio: Convert laio_aiocb_info.cancel
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v6 07/22] linux-aio: Convert laio_aiocb_info.cancel to .cancel_async |
Date: |
Thu, 11 Sep 2014 13:41:13 +0800 |
Just call io_cancel (2), if it fails, it means the request is not
canceled, so the event loop will eventually call
qemu_laio_process_completion.
In qemu_laio_process_completion, change to call the cb unconditionally.
It is required by bdrv_aio_cancel_async.
Signed-off-by: Fam Zheng <address@hidden>
---
block/linux-aio.c | 30 ++++++++----------------------
1 file changed, 8 insertions(+), 22 deletions(-)
diff --git a/block/linux-aio.c b/block/linux-aio.c
index 9aca758..b67f56c 100644
--- a/block/linux-aio.c
+++ b/block/linux-aio.c
@@ -85,9 +85,8 @@ static void qemu_laio_process_completion(struct
qemu_laio_state *s,
ret = -EINVAL;
}
}
-
- laiocb->common.cb(laiocb->common.opaque, ret);
}
+ laiocb->common.cb(laiocb->common.opaque, ret);
qemu_aio_release(laiocb);
}
@@ -153,35 +152,22 @@ static void laio_cancel(BlockDriverAIOCB *blockacb)
struct io_event event;
int ret;
- if (laiocb->ret != -EINPROGRESS)
+ if (laiocb->ret != -EINPROGRESS) {
return;
-
- /*
- * Note that as of Linux 2.6.31 neither the block device code nor any
- * filesystem implements cancellation of AIO request.
- * Thus the polling loop below is the normal code path.
- */
+ }
ret = io_cancel(laiocb->ctx->ctx, &laiocb->iocb, &event);
- if (ret == 0) {
- laiocb->ret = -ECANCELED;
+ laiocb->ret = -ECANCELED;
+ if (ret != 0) {
+ /* iocb is not cancelled, cb will be called by the event loop later */
return;
}
- /*
- * We have to wait for the iocb to finish.
- *
- * The only way to get the iocb status update is by polling the io context.
- * We might be able to do this slightly more optimal by removing the
- * O_NONBLOCK flag.
- */
- while (laiocb->ret == -EINPROGRESS) {
- qemu_laio_completion_cb(&laiocb->ctx->e);
- }
+ laiocb->common.cb(laiocb->common.opaque, laiocb->ret);
}
static const AIOCBInfo laio_aiocb_info = {
.aiocb_size = sizeof(struct qemu_laiocb),
- .cancel = laio_cancel,
+ .cancel_async = laio_cancel,
};
static void ioq_init(LaioQueue *io_q)
--
1.9.3
- [Qemu-devel] [PATCH v6 00/22] block: Asynchronous request cancellation, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 01/22] ide/ahci: Check for -ECANCELED in aio callbacks, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 02/22] block: Add refcnt in BlockDriverAIOCB, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 03/22] block: Add bdrv_aio_cancel_async, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 04/22] block: Drop bdrv_em_co_aiocb_info.cancel, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 05/22] block: Drop bdrv_em_aiocb_info.cancel, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 06/22] thread-pool: Convert thread_pool_aiocb_info.cancel to cancel_async, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 07/22] linux-aio: Convert laio_aiocb_info.cancel to .cancel_async,
Fam Zheng <=
- [Qemu-devel] [PATCH v6 08/22] dma: Convert dma_aiocb_info.cancel to .cancel_async, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 09/22] iscsi: Convert iscsi_aiocb_info.cancel to .cancel_async, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 10/22] archipelago: Drop archipelago_aiocb_info.cancel, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 11/22] blkdebug: Drop blkdebug_aiocb_info.cancel, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 12/22] blkverify: Drop blkverify_aiocb_info.cancel, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 13/22] curl: Drop curl_aiocb_info.cancel, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 14/22] qed: Drop qed_aiocb_info.cancel, Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 15/22] quorum: fix quorum_aio_cancel(), Fam Zheng, 2014/09/11
- [Qemu-devel] [PATCH v6 16/22] quorum: Convert quorum_aiocb_info.cancel to .cancel_async, Fam Zheng, 2014/09/11