[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] gdbstub: init mon_chr through qemu_chr_alloc
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] gdbstub: init mon_chr through qemu_chr_alloc |
Date: |
Thu, 11 Sep 2014 10:25:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 10/09/2014 16:34, Pavel Dovgalyuk ha scritto:
> This patch initializes monitor for gdbstub with the qemu_chr_alloc function
> instead of just allocating the memory. Initialization function call
> is required, because it also creates chr_write_lock mutex, which is used
> when writing to this character device.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---
> gdbstub.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gdbstub.c b/gdbstub.c
> index 8afe0b7..71aaa23 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -1707,7 +1707,7 @@ int gdbserver_start(const char *device)
> qemu_add_vm_change_state_handler(gdb_vm_state_change, NULL);
>
> /* Initialize a monitor terminal for gdb */
> - mon_chr = g_malloc0(sizeof(*mon_chr));
> + mon_chr = qemu_chr_alloc();
> mon_chr->chr_write = gdb_monitor_write;
> monitor_init(mon_chr, 0);
> } else {
>
Thanks, will send a pull request soon.
Paolo