[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report
From: |
Gonglei (Arei) |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report |
Date: |
Fri, 12 Sep 2014 08:50:55 +0000 |
> From: Paolo Bonzini [mailto:address@hidden On Behalf Of Paolo
> Bonzini
> Sent: Friday, September 12, 2014 4:35 PM
> To: Gonglei (Arei); address@hidden
> Cc: Huangweidong (C); address@hidden; address@hidden
> Subject: Re: [PATCH v2 0/2] usb: Don't use qerror_report
>
> Il 12/09/2014 09:30, address@hidden ha scritto:
> > From: Gonglei <address@hidden>
> >
> > qerror_report() is a transitional interface to help with converting
> > existing HMP commands to QMP. It should not be used elsewhere.
> >
> > v2 -> v1:
> > - update including head files, remove qerror.h and monitor.h,
> > add error-report.h (Markus)
> > - add 'Reviewed-by' tag.
> >
> > Gonglei (2):
> > redirect.c: Don't use qerror_report()
> > dev-network: Don't use qerror_report_err()
> >
> > hw/usb/dev-network.c | 4 ++--
> > hw/usb/redirect.c | 8 ++++----
> > 2 files changed, 6 insertions(+), 6 deletions(-)
> >
>
> This is not an improvement I think; patch 1 especially for patch 2 where
> you are discarding the Error *.
>
> Any chance you could convert USB from init to realize, instead? Then
> you can remove the error printing altogether, and just the obsolete
> functions.
>
As far as I can tell, almost all devices belong to USB sub-system are
using init method. It may be a big surgery if change all those devices
from init to realize. :)
Best regards,
-Gonglei