[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 23/23] block: Make device model's references to B
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 23/23] block: Make device model's references to BlockBackend strong |
Date: |
Sat, 13 Sep 2014 17:00:27 +0200 |
Doesn't make a difference just yet, but it's the right thing to do.
Signed-off-by: Markus Armbruster <address@hidden>
---
block/block-backend.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index 9c504f3..17285ba 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -251,6 +251,7 @@ int blk_attach_dev(BlockBackend *blk, void *dev)
if (blk->dev) {
return -EBUSY;
}
+ blk_ref(blk);
blk->dev = dev;
bdrv_iostatus_reset(blk->bs);
@@ -279,9 +280,10 @@ void blk_detach_dev(BlockBackend *blk, void *dev)
/* TODO change to DeviceState *dev when all users are qdevified */
{
assert(blk->dev == dev);
- blk->dev = NULL;
blk->dev_ops = NULL;
blk->dev_opaque = NULL;
+ blk->dev = NULL;
+ blk_unref(blk);
bdrv_set_guest_block_size(blk->bs, 512);
qemu_coroutine_adjust_pool_size(-COROUTINE_POOL_RESERVATION);
}
--
1.9.3
- [Qemu-devel] [PATCH v2 07/23] block: Eliminate bdrv_iterate(), use bdrv_next(), (continued)
- [Qemu-devel] [PATCH v2 16/23] pc87312: Drop unused members of PC87312State, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 15/23] ide: Complete conversion from BlockDriverState to BlockBackend, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 17/23] blockdev: Drop superfluous DriveInfo member id, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 21/23] blockdev: Convert qmp_eject(), qmp_change_blockdev() to BlockBackend, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 20/23] block/qapi: Convert qmp_query_block() to BlockBackend, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 23/23] block: Make device model's references to BlockBackend strong,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 19/23] blockdev: Drop DriveInfo member enable_auto_del, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 11/23] block: Rename BlockDriverAIOCB* to BlockAIOCB*, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 18/23] blockdev: Fix blockdev-add not to create IDE drive (0, 0), Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 22/23] block: Lift device model API into BlockBackend, Markus Armbruster, 2014/09/13
- [Qemu-devel] [PATCH v2 14/23] hw: Convert from BlockDriverState to BlockBackend, mostly, Markus Armbruster, 2014/09/13
- Re: [Qemu-devel] [PATCH v2 00/23] Split BlockBackend off BDS with an axe, Markus Armbruster, 2014/09/16