Re: [Qemu-devel] [RFC V2 10/10] cpus: reclaim allocated vCPU objects

[Bharata B Rao]

On Mon, Sep 15, 2014 at 12:09 PM, Gu Zheng <address@hidden> wrote:
> Hi Bharata,
> On 09/12/2014 09:52 PM, Bharata B Rao wrote:
>
>> On Fri, Sep 12, 2014 at 4:23 PM, Anshul Makkar
>> <address@hidden> wrote:
>>> During plugging we can see this event: echo 1 > cpu8/online.
>>>
>>> But during unplugging , we can't see the event echo 0 > cpu8/online.
>>
>> That's because I didn't do that explicitly, was always trying to
>> remove an online cpu from the monitor w/o explicitly offlining it from
>> inside the guest. Either ways I still see the removed CPU being listed
>> in QEMU monitor.
>>
>> I don't ever hit any of the below code paths during CPU removal:
>
> It seems that the guest OS did not call the "_EJ0" method.
> Could you please dump the guest os' acpi dsdt, and check whether the "_EJ0"
> method exists?

_EJ0 doesn't exist in my DSDT.

>
>>
>> cpus.c: qemu_kvm_destroy_vcpu()
>> cpus.c: x86_cpu_finalizefn()
>>
>> I see CPU_REMOVE() being called from above two routines.
>>
>> And neither does hw/acpi/cpu_hotplug.c:cpu_status_write() gets called
>> here. Does the message "ACPI: Device does not support D3cold" guest
>> kernel throws during hot removal is causing this behaviour here ?
>> Guest kernel is 3.11.10, should I be on latest kernel ?
>
> I have tested the fedora 20 guest with the default kernel, it works well,
> so the kernel should be fine.
> One more question, is the guest kernel config the same as fedora 20's default 
> one?

Yes, I am running the distro provided kernel.

Regards,
Bharata.