[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include fi
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file |
Date: |
Mon, 15 Sep 2014 13:55:06 +0300 |
On Mon, Sep 15, 2014 at 12:40:07PM +0200, Gerd Hoffmann wrote:
> > > > > +
> > > > > +enum virtgpu_ctrl_type {
> > > > > + VIRTGPU_UNDEFINED = 0,
> > > > > +
> > > > > + /* 2d commands */
> > > > > + VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100,
> > > >
> > > > Please consider also adding:
> >
> > VIRTIO_GPU_ everywhere to make it consistent with other
> > virtio headers?
>
> The names are already pretty long as-is, especially considering the
> 80cols rule in our codestyle. I'd prefer to keep them the way they are
> now.
>
> cheers,
> Gerd
>
VIRTIO_GPU_ is not longer than VIRTIO_NET_ is it?
VIRTGRU seems too generic.
--
MST
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, (continued)
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Peter Maydell, 2014/09/12
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Michael S. Tsirkin, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Peter Maydell, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Michael S. Tsirkin, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Peter Maydell, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Michael S. Tsirkin, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Peter Maydell, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Michael S. Tsirkin, 2014/09/14
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Gerd Hoffmann, 2014/09/15
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Gerd Hoffmann, 2014/09/15
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file,
Michael S. Tsirkin <=
Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Peter Maydell, 2014/09/11
[Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt, Gerd Hoffmann, 2014/09/11