[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib betwee
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38 |
Date: |
Tue, 16 Sep 2014 19:57:39 +0300 |
On Tue, Sep 16, 2014 at 09:45:03AM -0700, Peter Maydell wrote:
> On 16 September 2014 09:33, Paolo Bonzini <address@hidden> wrote:
> > Il 16/09/2014 18:28, Peter Maydell ha scritto:
> >>> > Though you would just drop support for "make check" on RHEL5. Even
> >>> > "make -k check" would roughly work.
> >> Can't we just put in the makefile and configure magic to skip
> >> the test if the glib version is too old for it?
> >
> > Yes, that's what Michael did (minus the magic to use the older
> > fork-based code). But is it really worthwhile to support RHEL5? We
> > made glib mandatory in 2011 (around RHEL6.2), and that broke RHEL4. By
> > the time the next QEMU release is ready RHEL7.1 should be out, give or
> > take a month or so.
>
> I care because in the EDA tools space things move very slowly
> and so RHEL5 is still fairly commonplace. Obviously at some
> point we're going to end up dropping support, but "one test
> case won't build" seems like a pretty trivial reason to drop
> it to me.
>
> -- PMM
Could you pls tell me whether my patch works, in your testing?
My box which had such an old glib seems to be dead.
- [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Paolo Bonzini, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Michael S. Tsirkin, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Peter Maydell, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Paolo Bonzini, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Peter Maydell, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Paolo Bonzini, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Peter Maydell, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Peter Maydell, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Michael S. Tsirkin, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Michael S. Tsirkin, 2014/09/16
- Re: [Qemu-devel] [RFC PATCH] tests: use g_test_trap_fork for glib between 2.16 and 2.38, Michael S. Tsirkin, 2014/09/16