Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

[Gonglei (Arei)]

> From: Paolo Bonzini [mailto:address@hidden
> Sent: Thursday, September 18, 2014 6:09 PM
> Subject: Re: [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize
> 
> Il 18/09/2014 11:32, address@hidden ha scritto:
> >  static void usb_msd_password_cb(void *opaque, int err)
> >  {
> >      MSDState *s = opaque;
> > +    Error *local_err = NULL;
> >
> > -    if (!err)
> > -        err = usb_device_attach(&s->dev);
> > +    if (!err) {
> > +        usb_device_attach(&s->dev, &local_err);
> > +    }
> >
> > -    if (err)
> > +    if (local_err) {
> > +        error_report("%s", error_get_pretty(local_err));
> 
> I think this should use qerror_report_err.
> 
OK.

Best regards,
-Gonglei