[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 14/15] qtest/ahci: Add human-readable command names
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH 14/15] qtest/ahci: Add human-readable command names |
Date: |
Thu, 18 Sep 2014 19:43:38 -0400 |
Instead of using direct hex values, use SATA command mnemonics.
Signed-off-by: John Snow <address@hidden>
---
tests/ahci-test.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 63fc309..e3091b9 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -265,6 +265,14 @@
#define CMDH_RES (0x800)
#define CMDH_PMP (0xF000)
+/* ATA Commands */
+enum {
+ CMD_READ_DMA = 0xC8,
+ CMD_WRITE_DMA = 0xCA,
+ CMD_FLUSH_CACHE = 0xE7,
+ CMD_IDENTIFY = 0xEC
+};
+
/*** Structures ***/
typedef struct AHCIPortState {
@@ -1673,7 +1681,7 @@ static void ahci_test_identify(AHCIState *ahci)
g_assert(data_ptr);
/* Construct the Command Table (FIS and PRDT) */
- table_ptr = build_cmd_table(ahci, i, 512, 0xEC, data_ptr);
+ table_ptr = build_cmd_table(ahci, i, 512, CMD_IDENTIFY, data_ptr);
/* Pick a command slot and link it to the command table we've built */
cx = link_cmd_slot(ahci, i, table_ptr, CMDH_READ);
--
1.9.3
- [Qemu-devel] [PATCH 03/15] qtest/ahci: Add port_clear helper, (continued)
- [Qemu-devel] [PATCH 03/15] qtest/ahci: Add port_clear helper, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 04/15] qtest/ahci: Add command header helpers, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 05/15] qtest/ahci: Add build cmd table helper, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 06/15] qtest/ahci: Add link_cmd_slot helper, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 07/15] qtest/ahci: Add port_check_error helper, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 08/15] qtest/ahci: Add issue_command helper, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 09/15] qtest/ahci: Add port_check_interrupts helper, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 10/15] qtest/ahci: Add port_check_nonbusy helper, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 11/15] qtest/ahci: Add cmd response sanity check helpers, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 12/15] qtest/ahci: Enforce zero-leaks for guest mem usage, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 14/15] qtest/ahci: Add human-readable command names,
John Snow <=
- [Qemu-devel] [PATCH 13/15] qtest/ahci: Add a macro bootup routine, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 15/15] qtest/ahci: Don't use a magic constant for buffer size, John Snow, 2014/09/18
- [Qemu-devel] [PATCH 01/15] qtest/ahci: Add AHCIState structure, John Snow, 2014/09/18
- Re: [Qemu-devel] [PATCH 00/15] AHCI test helper refactors, Markus Armbruster, 2014/09/19