[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] vmdk: Fix integer overflow in offset calcula
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v4] vmdk: Fix integer overflow in offset calculation |
|
Date: |
Mon, 22 Sep 2014 10:56:53 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 22, 2014 at 03:15:44PM +0800, Fam Zheng wrote:
> This fixes the bug introduced by commit c6ac36e (vmdk: Optimize cluster
> allocation).
>
> $ ~/build/master/qemu-io /stor/vm/arch.vmdk -c 'write 2G 1k'
> write failed: Invalid argument
>
> Reported-by: Mark Cave-Ayland <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
>
> ---
> v4: Fix typo in file header: 1014 -> 2014.
> v3: A new case 105 instead of embedding in 005. (Max)
> ---
> block/vmdk.c | 2 +-
> tests/qemu-iotests/105 | 70
> ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/105.out | 21 ++++++++++++++
> 3 files changed, 92 insertions(+), 1 deletion(-)
> create mode 100755 tests/qemu-iotests/105
> create mode 100644 tests/qemu-iotests/105.out
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgphjoqDBh_jT.pgp
Description: PGP signature