[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst |
Date: |
Tue, 23 Sep 2014 20:42:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 23/09/2014 19:48, Peter Maydell ha scritto:
> On 22 September 2014 23:19, Paolo Bonzini <address@hidden> wrote:
>> Il 22/09/2014 22:57, Richard Henderson ha scritto:
>>> +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32);
>>> +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8);
>>> +
>>> typedef struct TCGLabelQemuLdst {
>>> - bool is_ld:1; /* qemu_ld: true, qemu_st: false */
>>> - TCGMemOp opc:4;
>>> - TCGReg addrlo_reg; /* reg index for low word of guest virtual
>>> addr */
>>> - TCGReg addrhi_reg; /* reg index for high word of guest virtual
>>> addr */
>>> - TCGReg datalo_reg; /* reg index for low word to be loaded or
>>> stored */
>>> - TCGReg datahi_reg; /* reg index for high word to be loaded or
>>> stored */
>>> - int mem_index; /* soft MMU memory index */
>>> + TCGMemOp opc : 4;
>>> + bool is_ld : 1; /* qemu_ld: true, qemu_st: false */
>>> + TCGReg addrlo_reg : 5; /* reg index for low word of guest virtual
>>> addr */
>>> + TCGReg addrhi_reg : 5; /* reg index for high word of guest virtual
>>> addr */
>>> + TCGReg datalo_reg : 5; /* reg index for low word to be loaded or
>>> stored */
>>> + TCGReg datahi_reg : 5; /* reg index for high word to be loaded or
>>> stored */
>>> + unsigned mem_index : 3; /* soft MMU memory index */
>>> + /* 4 bits unused in 32-bit word */
>>
>> Why? Are there more than 10 or so loads in the typical tb?
>
> For clarity, does this comment amount to a request for
> me not to apply this pullreq?
No, it just caught my eye because it'll conflict with the PPC patches
that have NB_MMU_MODES == 12.
Paolo
- [Qemu-devel] [PULL 00/11] tcg updates, Richard Henderson, 2014/09/22
- [Qemu-devel] [PULL 01/11] tcg-sparc: Support addsub2_i64, Richard Henderson, 2014/09/22
- [Qemu-devel] [PULL 02/11] tcg-sparc: Use ADDXC in addsub2_i64, Richard Henderson, 2014/09/22
- [Qemu-devel] [PULL 04/11] tcg-sparc: Use ADDXC in setcond_i64, Richard Henderson, 2014/09/22
- [Qemu-devel] [PULL 03/11] tcg-sparc: Fix setcond_i32 uninitialized value, Richard Henderson, 2014/09/22
- [Qemu-devel] [PULL 05/11] tcg-sparc: Rename ADDX/SUBX insns, Richard Henderson, 2014/09/22
- [Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst, Richard Henderson, 2014/09/22
[Qemu-devel] [PULL 06/11] tcg-sparc: Use UMULXHI instruction, Richard Henderson, 2014/09/22
[Qemu-devel] [PULL 08/11] tcg: Move TCG_TYPE_COUNT out of enum TCGType, Richard Henderson, 2014/09/22
[Qemu-devel] [PULL 10/11] qemu/compiler: Define QEMU_ARTIFICIAL, Richard Henderson, 2014/09/22
[Qemu-devel] [PULL 11/11] tcg: Always enable TCGv type checking, Richard Henderson, 2014/09/22
[Qemu-devel] [PULL 09/11] tcg-aarch64: Use 32-bit loads for qemu_ld_i32, Richard Henderson, 2014/09/22