Re: [Qemu-devel] [PATCH qom v3 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs

[Andreas Färber]

Am 26.09.2014 um 15:13 schrieb Paolo Bonzini:
> Il 26/09/2014 07:16, Peter Crosthwaite ha scritto:
>> Hi All,
>>
>> So phase one was the QOMification of qemu_irq. This is the next step.
>> We start to setup GPIOs as proper QOM objects. Inputs are child objects
>> of their device. Outputs are settable Links and connection is made
>> via proper setting of a QOM link.
>>
>> We then cleanup Sysbus to simply re-use device level GPIOs and get rid
>> of it's special IRQ handling code.
>>
>> CHanged since v2:
>> Remove num_irq from sysbus (P14)
>> Removed out of tree deps.
>> Changed since v1:
>> Addressed Alex review
>> Dropped IRQ g_new0 changes
>>
>>
>>
>> Peter Crosthwaite (14):
>>   qdev: gpio: Don't allow name share between I and O
>>   qdev: gpio: Register GPIO inputs as child objects
>>   qdev: gpio: Register GPIO outputs as QOM links
>>   qmp: qstring: Handle NULL strings
>>   qom: Allow clearing of a Link property
>>   qom: Demote already-has-a-parent to a regular error
>>   qdev: gpio: Re-impement qdev_connect_gpio QOM style
>>   qdev: gpio: Add API for intercepting a GPIO
>>   qtest/irq: Rework IRQ interception
>>   irq: Remove qemu_irq_intercept_out
>>   qdev: gpio: delete NamedGPIOList::out
>>   qdev: gpio: Remove qdev_init_gpio_out x1 restriction
>>   qdev: gpio: Define qdev_pass_gpios()
>>   sysbus: Use TYPE_DEVICE GPIO functionality
>>
>>  hw/core/irq.c          |  8 +----
>>  hw/core/qdev.c         | 90 
>> ++++++++++++++++++++++++++++++++++++++++++++++----
>>  hw/core/sysbus.c       | 20 ++---------
>>  include/hw/irq.h       |  1 -
>>  include/hw/qdev-core.h |  6 +++-
>>  include/hw/sysbus.h    |  7 ++--
>>  qobject/qstring.c      | 12 ++++---
>>  qom/object.c           | 10 ++++--
>>  qtest.c                | 15 ++++++---
>>  9 files changed, 120 insertions(+), 49 deletions(-)
>>
> 
> Apart from the couple of patches I replied to,
> 
> Reviewed-by: Paolo Bonzini <address@hidden>
> 
> Alex, do you want to pick it up and send it together with your sysbus
> patches?

I had started picking up the initial ones from v2 after Alex' ping...

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg