qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 1/2] dump: let dump_error return error info t


From: zhanghailiang
Subject: Re: [Qemu-devel] [PATCH v6 1/2] dump: let dump_error return error info to caller
Date: Mon, 29 Sep 2014 16:06:22 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.1.1

On 2014/9/29 15:48, Markus Armbruster wrote:
zhanghailiang <address@hidden> writes:

The second parameter of dump_error is unused, but one purpose of
using this function is to report the error info.

Use error_set to return the error info to the caller.

Signed-off-by: zhanghailiang <address@hidden>

The commit message doesn't explain this patch's benefit clearly.
Suggest:

     dump: Propagate errors into qmp_dump_guest_memory()

     The code calls dump_error() on error, and even passes it a suitable
     message.  However, the message is thrown away, and its callers pass
     up only success/failure.  All qmp_dump_guest_memory() can do is set
     a generic error.

     Propagate the errors properly, so qmp_dump_guest_memory() can return
     a more useful error.

With a commit message like that:

Reviewed-by: Markus Armbruster <address@hidden>



OK, Will fix like that, and submit V7, thanks very much;)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]