|
From: | Michael Walle |
Subject: | [Qemu-devel] ui/gtk.c does not check qemu_chr_be_can_write() |
Date: | Mon, 29 Sep 2014 15:15:11 +0200 |
User-agent: | Roundcube Webmail/0.9.5 |
Hi Anthony, Hi Gerd,the GTK frontend does not respect the the "chr_can_read" hook. The frontend just writes characters to the device using qemu_chr_be_write() without checking if the device can receive any input (qemu_chr_be_can_write()).
At least for my device model (hw/char/milkymist-uart.c), this results in an assertion because the rx callback asserts if there is already a character in the buffer. It assumes that the uart_rx callback is only called, if the uart_can_rx callback returns a value >0.
Do I make a wrong assumption here? -michael
[Prev in Thread] | Current Thread | [Next in Thread] |