Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in PropertyInfo struct

[Michael S. Tsirkin]

On Tue, Sep 30, 2014 at 09:14:50PM +0800, Gonglei wrote:
> > Subject: Re: [Qemu-devel] [PATCH v4 1/5] qdev: add description field in
> > PropertyInfo struct
> > 
> > On Tue, Sep 30, 2014 at 11:02:35AM +0800, address@hidden wrote:
> > > @@ -552,6 +556,7 @@ static int print_pci_devfn(DeviceState *dev, Property
> > *prop, char *dest,
> > >  PropertyInfo qdev_prop_pci_devfn = {
> > >      .name  = "int32",
> > 
> > Is this name used anywhere? It seems wrong ...
> > 
> The Propertyinfo.name is used to the qdev property's type, please see PATCH 4:
> 
> -            info->type = g_strdup(prop->info->legacy_name ?: 
> prop->info->name);
> +            info->type = g_strdup(prop->info->name);

I would say this one is more a string than an int.

> > >      .legacy_name  = "pci-devfn",
> > > +    .description = "Slot and function number, example: 06.0",
> > 
> > In fact, .0 can be omitted. So please make this:
> > Slot and optional function number, examples: 06.0 or 06.
> > 
> OK. Thanks.
> 
> Best regards,
> -Gonglei
>